feat(regionserver): add graceful shutdown configuration#570
Merged
Conversation
Extract region configuration into it's own structure. Refactor the lib and controller modules to work with the new structure in a slightly generic way.
docs/modules/hbase/pages/usage-guide/operations/graceful-shutdown.adoc
Outdated
Show resolved
Hide resolved
…own.adoc Co-authored-by: Nick <10092581+NickLarsenNZ@users.noreply.github.com>
Member
Author
|
Updated and it now requires stackabletech/docker-images#974 |
siegfriedweber
requested changes
Feb 5, 2025
Co-authored-by: Siegfried Weber <mail@siegfriedweber.net>
Member
Author
Thanks! |
sbernauer
reviewed
Feb 7, 2025
Comment on lines
+691
to
+693
| hbaseOpts: | ||
| nullable: true | ||
| type: string |
Member
There was a problem hiding this comment.
I think this should not be added again (applies to all roles).
#620 removed it, can you please remove it again?
|
|
||
| /// JVM arguments that specifically for the role (server), so will *not* be used e.g. by CLI tools | ||
| fn construct_role_specific_jvm_args( | ||
| /// Arguments that go into `HBASE_OPTS`, so *not* the heap settings (which go into `HBASE_HEAPSIZE`). |
Member
There was a problem hiding this comment.
Actually they are role specific, so they do not go into HBASE_OPTS.
Instead they go into HBASE_MASTER_OPTS and others
Maybe something like
/// JVM arguments that are specifically for the role (server), so will *not* be used e.g. by CLI tools.
/// Heap settings are excluded, as they go into `HBASE_HEAPSIZE`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
part of: #508
requires: stackabletech/docker-images#898
Implementation for "approach B" in https://github.com/stackabletech/decisions/issues/30
Definition of Done Checklist